Fix error message(LinuixIdMapping to uid_mappings)
#318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
utam0k
reviewed
Sep 21, 2021
src/rootless.rs
Outdated
| @@ -100,7 +100,7 @@ fn validate(spec: &Spec) -> Result<()> { | |||
| let uid_mappings = linux | |||
| .uid_mappings | |||
| .as_ref() | |||
| .context("rootless containers require LinuxIdMapping in spec")?; | |||
| .context("rootless containers require uid_mappings in spec")?; | |||
There was a problem hiding this comment.
Thanks for your PR. How about aligning to the runtime spec? This means it should be uidMappings.
https://github.com/opencontainers/runtime-spec/blob/master/config-linux.md#user-namespace-mappings
There was a problem hiding this comment.
Thank you for your advice. I fixed this.(uid_mappings -> uidMappings, gid_mappings -> gidMappings)
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 73.10% 70.98% -2.13%
==========================================
Files 44 46 +2
Lines 6545 6817 +272
==========================================
+ Hits 4785 4839 +54
- Misses 1760 1978 +218 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.